Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] DOC: Add missing attributes to SVC and NuSVC #14930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2019

Conversation

kwinata
Copy link
Contributor

@kwinata kwinata commented Sep 9, 2019

Reference Issues/PRs

Partially addresses #14312
Redoing PR from #14424

What does this implement/fix? Explain your changes.

Added class_weight_, fit_status_, probA_, probB_, shape_fit_ attributes docstring to NuSVC,
Added class_weight_, shape_fit_ attributes docstring to SVC.

Any other comments?

@kwinata kwinata changed the title Add missing attributes to SVC and NuSVC [MRG] DOC: Add missing attributes to SVC and NuSVC Sep 9, 2019
@glemaitre
Copy link
Member

@amueller @jnothman @rth do you think that the attributes fit_status_ and shape_fit_ should be private.

@jnothman
Copy link
Member

jnothman commented Sep 12, 2019 via email

@kwinata
Copy link
Contributor Author

kwinata commented Sep 13, 2019

I don't understand why the linting failed. It says

   .. [2] `Platt, John (1999). "Probabilistic outputs for support vector
        machines and comparison to regularizedlikelihood methods."
        <http://citeseer.ist.psu.edu/viewdoc/summary?doi=10.1.1.41.1639>`_
    """
                                                                          ^
sklearn/svm/classes.py:589:76: W291 trailing whitespace
    """C-Support Vector Classification.

But I can't find the trailing whitespace in the source. @glemaitre Any idea about this?

@glemaitre glemaitre self-requested a review September 13, 2019 08:10
@glemaitre
Copy link
Member

@kwinata The trailing space were there: 777265b

The issue is that flake8 shows the entire docstring which is not helpful in this case :)

@glemaitre
Copy link
Member

Waiting for the CI to be green but LGTM

@kwinata
Copy link
Contributor Author

kwinata commented Sep 13, 2019

@kwinata The trailing space were there: 777265b

The issue is that flake8 shows the entire docstring which is not helpful in this case :)

Thanks for the catch! 👍

@glemaitre glemaitre merged commit ba61dad into scikit-learn:master Sep 13, 2019
@glemaitre
Copy link
Member

Thanks @kwinata

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants