DOC don't suggest contributors to add type annotations #18718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. We can postpone the time annotation suggestion until we sign for it. |
glemaitre
approved these changes
Nov 1, 2020
rth
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current contributing guidelines suggest to "moderately" introduce type annotations in PRs.
I think that type annotations is something we need to discuss in more depth before we suggest contributors to add some (see #16705 (comment) and subsequent comments for discussions and current limitations/complications).
(I also feel like we should either go all in or not at all when it comes to introducing new standards in PRs.)
CC @rth ;)