DOC Ensures that make_column_transformer passes numpydoc #22183
Conversation
|
Hi @thomasjpfan, should I do any changes here or you'll review it first? |
There was a problem hiding this comment.
Thank you for the PR @atharvapatil123 !
We try to keep changes related to the title. In this case, please revert changes that are not in make_column_transformer and keep the changes in make_column_transformer.
| @@ -190,7 +190,7 @@ class ColumnTransformer(TransformerMixin, _BaseComposition): | |||
| >>> # row independently. | |||
| >>> ct.fit_transform(X) | |||
| array([[0. , 1. , 0.5, 0.5], | |||
| [0.5, 0.5, 0. , 1. ]]) | |||
| [0.5, 0.5, 0. , 1. ]]). | |||
There was a problem hiding this comment.
This change is unrelated to the title of the PR. We should revert.
Co-authored-by: Thomas J. Fan <[email protected]>
…scikit-learn into atharva-feature
|
Hi @thomasjpfan, I've made the necessary changes. Actually, sklearn.metrics.pairwise.manhattan_distances, and sklearn.metrics.pairwise.nan_euclidean_distances existed in the test_docstrings.py file. So, I had to remove them and commit again. I request you to merge this pull request as soon as possible after reviewing since I need to commit my remaining two PR's and this one is conflicting in those. |
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
DOC Ensures that make_column_transformer passes numpydoc validation
Any other comments?
No
Thank You