-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Ensures that kmeans_plusplus passes numpydoc validation #22197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Ensures that kmeans_plusplus passes numpydoc validation #22197
Conversation
Co-authored-by: Thomas J. Fan <[email protected]>
…scikit-learn into atharva-feature
I notice your branch git fetch upstream main
git checkout -b kmeans_plusplus_numpydoc upstream/main And you can work on just Edit: Correctly first command to be: |
I believe that:
should rather be read:
or even more explicitly:
if you do not have the |
Yes @ogrisel, I tried
However, it was not working
I believe this works correctly. Thanks! |
For future reference, the branching instructions are in the How to contribute docs (steps 5-8). In step 8, you can create new branch names. The instructions there are slightly different from here, but accomplish the same goal. |
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Added necessary periods for successful numpydoc validation in sklearn/cluster/_kmeans.py file, kmeans_plusplus() function
Any other comments?
No, Thank you