Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that kmeans_plusplus passes numpydoc validation #22197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

atharvapatil123
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Added necessary periods for successful numpydoc validation in sklearn/cluster/_kmeans.py file, kmeans_plusplus() function

Any other comments?

No, Thank you

@thomasjpfan
Copy link
Member

thomasjpfan commented Jan 12, 2022

I notice your branch atharva-feature is the same branch as #22183 and has the same commits. For future reference, it's best to create separate branches for each new PR. This way can work on separate tasks on different branches. For example:

git fetch upstream main
git checkout -b kmeans_plusplus_numpydoc upstream/main

And you can work on just kmeans_plusplus on the kmeans_plusplus_numpydoc branch.

Edit: Correctly first command to be: git fetch upstream main (Thanks @ogrisel)

@ogrisel
Copy link
Member

ogrisel commented Jan 14, 2022

I believe that:

git fetch upstream/main
git checkout -b kmeans_plusplus_numpydoc upstream/main

should rather be read:

git fetch upstream main
git checkout -b kmeans_plusplus_numpydoc upstream/main

or even more explicitly:

git fetch https://github.com/scikit-learn/scikit-learn main
git checkout -b kmeans_plusplus_numpydoc FETCH_HEAD

if you do not have the upstream remote alias defined (git remote -v to check your alias configuration).

@atharvapatil123
Copy link
Contributor Author

I believe that:

git fetch upstream/main
git checkout -b kmeans_plusplus_numpydoc upstream/main

should rather be read:

git fetch upstream main
git checkout -b kmeans_plusplus_numpydoc upstream/main

or even more explicitly:

git fetch https://github.com/scikit-learn/scikit-learn main
git checkout -b kmeans_plusplus_numpydoc FETCH_HEAD

if you do not have the upstream remote alias defined (git remote -v to check your alias configuration).

Yes @ogrisel, I tried

git fetch upstream/main

However, it was not working

git fetch upstream main

I believe this works correctly. Thanks!

@thomasjpfan
Copy link
Member

thomasjpfan commented Jan 14, 2022

For future reference, the branching instructions are in the How to contribute docs (steps 5-8). In step 8, you can create new branch names.

The instructions there are slightly different from here, but accomplish the same goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants