Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT Fix check_scalar error in trees #22302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 26, 2022

Conversation

thomasjpfan
Copy link
Member

Quick follow up to #22027 to fix breaking test on main.

@thomasjpfan
Copy link
Member Author

thomasjpfan commented Jan 25, 2022

It's really weird that sound of the instances are stuck.

@thomasjpfan
Copy link
Member Author

The issue stalling issue is resolved when pytest-xdist is disabled.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't really understand what is happening with parallel processing.

@glemaitre glemaitre self-assigned this Jan 26, 2022
@glemaitre
Copy link
Member

I just reactivated the pytest-xdist to check if the problem went away on its own.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel
Copy link
Member

ogrisel commented Jan 26, 2022

Let's wait for the run with pytest-xdist to complete.

@thomasjpfan
Copy link
Member Author

Let's wait for the run with pytest-xdist to complete.

I have been experimenting on my fork. I suspect we will need to disable pytest-xdist everywhere, since the instance that stalls is not predictable. Let's see what happens here.

@thomasjpfan
Copy link
Member Author

thomasjpfan commented Jan 26, 2022

Comparing a previous run where stalled builds were canceled and the most recent run with pytest-xdist enabled the jobs that stalled are not consistent.

Edit: Here is a run on my fork with verbose on + pytest-xdist trying to debug the issue.

@glemaitre
Copy link
Member

Is there any new library version triggering this?

@ogrisel
Copy link
Member

ogrisel commented Jan 26, 2022

Edit: Here is a run on my fork with verbose on + pytest-xdist trying to debug the issue.

On your verbose fork, the last test that PASSED on gw1 is inspection/tests/test_partial_dependence.py::test_partial_dependence_pipeline. Then there are plenty of tests running on gw0 only.

At the end:

utils/tests/test_weight_vector.py::test_type_invariance[float64-WeightVector64]

is started but never PASSED while the previous utils/tests/test_weight_vector.py::test_type_invariance[float32-WeightVector32] was PASSED on gw0.

Not sure what to make of this though...

@ogrisel
Copy link
Member

ogrisel commented Jan 26, 2022

The last build seems stalled even with pytest-xdist disabled. We need to activate the verbose mode.

Copy link
Member Author

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let the test stalled out to see what happens with --verbose.

@ogrisel
Copy link
Member

ogrisel commented Jan 26, 2022

It looks good, but maybe we should disable verbosity here before merging.

@glemaitre
Copy link
Member

The tests are passing. We need to investigate more but at least PRs will become greener.

@glemaitre glemaitre merged commit 2cdcf10 into scikit-learn:main Jan 26, 2022
@thomasjpfan
Copy link
Member Author

thomasjpfan commented Jan 26, 2022

BTW this stalling is kind of painful. Every PR that does not sync with upstream will need to wait +1 hours for jobs to stall out. This means PRs are taking up resources that prevents the CI from running on other PRs.

@glemaitre
Copy link
Member

True and we observe with @ogrisel that Azure was indicating that we were consuming too many credits.
I would propose to make a push in the PR for the latest PR when we see that contributors are around. It is a bit invasive but I don't see how to solve the problem otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants