-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MAINT Fix check_scalar error in trees #22302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's really weird that sound of the instances are stuck. |
The issue stalling issue is resolved when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't really understand what is happening with parallel processing.
I just reactivated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let's wait for the run with |
I have been experimenting on my fork. I suspect we will need to disable |
Comparing a previous run where stalled builds were canceled and the most recent run with pytest-xdist enabled the jobs that stalled are not consistent. Edit: Here is a run on my fork with verbose on + |
Is there any new library version triggering this? |
On your verbose fork, the last test that At the end:
is started but never Not sure what to make of this though... |
The last build seems stalled even with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let the test stalled out to see what happens with --verbose
.
It looks good, but maybe we should disable verbosity here before merging. |
The tests are passing. We need to investigate more but at least PRs will become greener. |
BTW this stalling is kind of painful. Every PR that does not sync with upstream will need to wait +1 hours for jobs to stall out. This means PRs are taking up resources that prevents the CI from running on other PRs. |
True and we observe with @ogrisel that Azure was indicating that we were consuming too many credits. |
Quick follow up to #22027 to fix breaking test on
main
.