Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Blog to top menu bar #22737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Add Blog to top menu bar #22737

merged 2 commits into from
Mar 9, 2022

Conversation

francoisgoupil
Copy link
Member

@francoisgoupil francoisgoupil commented Mar 9, 2022

Reference Issues/PRs

Fixes #22337. See also #65.

What does this implement/fix? Explain your changes.

It is adding a "Community" element to the top menu bar of scikit-learn.org pointing to blog.scikit-learn.org
Screenshot from 2022-03-09 16-51-14

@thomasjpfan
Copy link
Member

The navbar was designed to hold a finite number of items. With a new item and specific widths the navbar will look like this:

Screen Shot 2022-03-09 at 10 48 38 AM

I am okay with this for now.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@TomDLT TomDLT merged commit d6984db into scikit-learn:main Mar 9, 2022
@TomDLT
Copy link
Member

TomDLT commented Mar 9, 2022

Thanks @francoisgoupil !

@francoisgoupil francoisgoupil deleted the menu-blog branch March 9, 2022 21:07
francoisgoupil added a commit to francoisgoupil/scikit-learn that referenced this pull request Mar 11, 2022
francoisgoupil added a commit to francoisgoupil/scikit-learn that referenced this pull request Mar 11, 2022
adrinjalali pushed a commit that referenced this pull request Mar 12, 2022
* Add Blog to top menu bar (#22737)

Co-authored-by: Thomas J. Fan <[email protected]>

* Workaround numpydoc version issue

Co-authored-by: Thomas J. Fan <[email protected]>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Blog to top menu bar
3 participants