Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT Use _validate_params in NMF and MiniBatchNMF #23463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 29, 2022
Merged

MNT Use _validate_params in NMF and MiniBatchNMF #23463

merged 14 commits into from
Jun 29, 2022

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented May 25, 2022 •
edited by ogrisel
Loading

towards #23462

  • Use _validate_params in NMF and MiniBatchNMF
  • Small refactor to make both inherit from a base class because currently MiniBatchNMF holds some attributes that it should not like solver, alpha, ...
  • Use validate_params for the public non_negative_matrix_factorization

This is still WIP, waiting for #23459 (merged) and for a better way to test param validation on the public functions (proposed in #23514).

@haochunchang haochunchang mentioned this pull request May 30, 2022
Closed
@jeremiedbb jeremiedbb added the Validation related to input validation label Jun 13, 2022
@jeremiedbb jeremiedbb changed the title [WIP] MNT Use _validate_params in NMF and MiniBatchNMF MNT Use _validate_params in NMF and MiniBatchNMF Jun 22, 2022
@glemaitre glemaitre self-requested a review June 23, 2022 15:09
glemaitre
glemaitre reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@glemaitre
Copy link
Member

The failure seems unrelated (e.g. test_large_sparse_matrix[newton-cg]). We might keep an eye on this failure if this is linked to some random state issues.

glemaitre
glemaitre approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ogrisel
ogrisel approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be nice to follow up with a PR to clean-up the regularization deprecation handling.

@jeremiedbb
Copy link
Member Author

It might be nice to follow up with a PR to clean-up the regularization deprecation handling.

planed, but after 1.1.2 :)

@glemaitre glemaitre merged commit 4300b72 into scikit-learn:main Jun 29, 2022
@glemaitre
Copy link
Member

Thanks @jeremiedbb

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@jeremiedbb @ogrisel
MAINT Use _validate_params in NMF and MiniBatchNMF (scikit-learn#23463)
979e1d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:decomposition No Changelog Needed Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @glemaitre @ogrisel