LinearRegression uses _validate_parameters #23462 #23473
Conversation
This information is in the How to contribute section of the docs. It describes how to setup |
|
Thank you @thomasjpfan |
There was a problem hiding this comment.
LGTM!
Though I used from ..utils._param_validation import Integral in my PR, I think both are equivalent.
Quoting from https://scikit-learn.org/dev/developers/contributing.html#how-to-contribute point 8:
Always use a feature branch. It’s good practice to never work on the
mainbranch!
|
@haochunchang So should I raise a request to a different branch, or from a different branch from my repo? |
|
I see that a check is failing because I didn't add a changelog. Do I need to add one? If yes, can someone point me to the instructions for how to add it? I couldn't find one in the Contribution docs |
|
I think the source branch needs to be changed (different branch from your repo), you can refer to this SO question. The changelog check has message in the detail: https://github.com/scikit-learn/scikit-learn/runs/6625328247?check_suite_focus=true#step:4:26035 |
|
@haochunchang Raised a new PR from a different branch. #23491. Closing this one |
Reference Issues/PRs
LinearRegression uses _validate_parameters as part of #23462
What does this implement/fix? Explain your changes.
fitcalls_validate_parametersas the first stepAny other comments?
First contribution. So I have a question - What is the standard process used to organize imports and format code? I've seen some repos use
pre-commit. Is something similar being used here?Please let me know if I missed something. I'll fix it asap