Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT LinearRegression uses _validate_parameters #23491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2022
Merged

MNT LinearRegression uses _validate_parameters #23491

merged 3 commits into from
Jun 4, 2022

Conversation

BBloggsbott
Copy link
Contributor

Reference Issues/PRs

LinearRegression uses _validate_parameters as part of #23462

What does this implement/fix? Explain your changes.

  • The estimator defines a class attribute _parameter_constraints that defines the valid types and values for the parameters of the estimator.
  • fit calls _validate_parameters as the first step

Any other comments?

First contribution. So I have a question - What is the standard process used to organize imports and format code? I've seen some repos use pre-commit. Is something similar being used here?
Please let me know if I missed something. I'll fix it asap

@BBloggsbott BBloggsbott mentioned this pull request May 30, 2022
Closed
@jeremiedbb jeremiedbb changed the title LogisticRegression uses _validate_parameters LinearRegression uses _validate_parameters May 30, 2022
jeremiedbb
jeremiedbb reviewed May 30, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @BBloggsbott. We just need a feature (regarding deprecated params) that is not merged yet before merging this one

@BBloggsbott
Copy link
Contributor Author

Some checks are failing due to an error while downloading the action

Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/7884fcad6b5d53d10323aee724dc68d8b9096a2e'. Error: Response status code does not indicate success: 503 (Service Unavailable).

Can someone run the checks again please?

@BBloggsbott BBloggsbott requested a review from jeremiedbb June 3, 2022 08:19
jeremiedbb
jeremiedbb approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @BBloggsbott !

@haochunchang haochunchang mentioned this pull request Jun 3, 2022
Merged
@thomasjpfan thomasjpfan changed the title LinearRegression uses _validate_parameters MNT LinearRegression uses _validate_parameters Jun 4, 2022
@thomasjpfan thomasjpfan merged commit 4b59c15 into scikit-learn:main Jun 4, 2022
@BBloggsbott BBloggsbott deleted the linear-regression-validate-params branch June 5, 2022 16:01
@reshamas reshamas mentioned this pull request Jun 11, 2022
Closed
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@BBloggsbott @ogrisel
MNT LinearRegression uses _validate_parameters (scikit-learn#23491)
5b6a485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BBloggsbott @ogrisel @thomasjpfan @jeremiedbb