MAINT Create private _pairwise_distances_reductions submodule
#23724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those interfaces are meant to be used in the Python code, decoupling the actual implementation from the Python code. This allows changing all the private implementation while maintaining a contract for the Python callers. Each interface extending the base `PairwiseDistancesReduction` interface must implement the :meth:`compute` classmethod. Under the hood, such a function must only define the logic to dispatch at runtime to the correct dtype-specialized `PairwiseDistancesReduction` implementation based on the dtype of X and of Y. This refactoring will ease other dtype support such as float32 support.
… with some ASCII art. 🎨 Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Also reword comments in tests
From: #14 (review) Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb
reviewed
Jun 23, 2022
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Thanks for the review. It definitely was time to.
Just a re-factoring left-over. |
Co-authored-by: Olivier Grisel <[email protected]>
thomasjpfan
reviewed
Jun 23, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
…eds] test_chunk_size_agnosticism test_n_threads_agnosticism test_strategies_consistency test_pairwise_distances_argkmin test_pairwise_distances_radius_neighbors test_sqeuclidean_row_norms Co-authored-by: Thomas J. Fan <[email protected]>
test_chunk_size_agnosticism test_n_threads_agnosticism test_strategies_consistency test_pairwise_distances_argkmin test_pairwise_distances_radius_neighbors test_sqeuclidean_row_norms
ogrisel
added a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…it-learn#23724) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up of #23515.
What does this implement/fix? Explain your changes.
The single source file is split in several files to create a private submodule:
treesubmodule)Any other comments?