ENH Add verbose to classifier regressor chains #23977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_samples, n_classes
…e chain, per order parameter
…fiegel/scikit-learn into verbose-to-classifier-regressor-chains pulling from GitHub
Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Chiara Marmo <[email protected]>
thomasjpfan
approved these changes
Jul 26, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Minor comment on the whats new. Otherwise LGTM
doc/whats_new/v1.2.rst
Outdated
| :mod:`sklearn.multioutput` | ||
| .......................... | ||
|
|
||
| - |API| Added boolean `verbose` flag to classes: |
Member
There was a problem hiding this comment.
I'll say this is a feature:
Suggested change
| - |API| Added boolean `verbose` flag to classes: | |
| - |Feature| Added boolean `verbose` flag to classes: |
According to our legend:
scikit-learn/doc/whats_new/changelog_legend.inc
Lines 11 to 12 in 79c21c5
"API" is used for API changes.
jeremiedbb
reviewed
Jul 26, 2022
thomasjpfan
reviewed
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16380
Closes #18947 (supersedes)
What does this implement/fix? Explain your changes.
Adds a boolean verbose option to
ClassifierChainandRegressorChain.Any other comments?