API add verbose argument in ClassifierChain and RegressorChain - #18947
API add verbose argument in ClassifierChain and RegressorChain#18947efiegel wants to merge 19 commits into
Conversation
…_samples, n_classes
…e chain, per order parameter
…fiegel/scikit-learn into verbose-to-classifier-regressor-chains pulling from GitHub
cmarmo
left a comment
There was a problem hiding this comment.
@efiegel thanks for your pull request. I've made some comments waiting for a core-dev review.
Also keep in mind that this is a new feature so it will need a what's new entry describing the new option and referring to your pull request.... as we are in the middle of a release you might want to wait some time ... I don't know myself if the release after will be 0.25 or 1.0 ... :D
glemaitre
left a comment
There was a problem hiding this comment.
Regarding the what's new entry, you can add it in 1.0 file.
Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Chiara Marmo <[email protected]>
|
Thanks @glemaitre @cmarmo! Should have all your feedback folded in. |
|
Thanks @efiegel for your patience! Do you mind updating to upstream/main (again...sorry for that)? This and the "Waiting for reviewer" should bring more attention I hope. |
Reference Issues/PRs
Fixes #16380
What does this implement/fix? Explain your changes.
Adds a boolean verbose option to
ClassifierChainandRegressorChain.Follows the examples of #11364 and #16069.