-
-
Notifications
You must be signed in to change notification settings - Fork 26k
API add verbose argument in ClassifierChain and RegressorChain #18947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API add verbose argument in ClassifierChain and RegressorChain #18947
Conversation
…_samples, n_classes
…e chain, per order parameter
…fiegel/scikit-learn into verbose-to-classifier-regressor-chains pulling from GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efiegel thanks for your pull request. I've made some comments waiting for a core-dev review.
Also keep in mind that this is a new feature so it will need a what's new entry describing the new option and referring to your pull request.... as we are in the middle of a release you might want to wait some time ... I don't know myself if the release after will be 0.25 or 1.0 ... :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the what's new entry, you can add it in 1.0
file.
Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Chiara Marmo <[email protected]>
Thanks @glemaitre @cmarmo! Should have all your feedback folded in. |
Thanks @efiegel for your patience! Do you mind updating to upstream/main (again...sorry for that)? This and the "Waiting for reviewer" should bring more attention I hope. |
Reference Issues/PRs
Fixes #16380
What does this implement/fix? Explain your changes.
Adds a boolean verbose option to
ClassifierChain
andRegressorChain
.Follows the examples of #11364 and #16069.