API add verbose argument in ClassifierChain and RegressorChain #18947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_samples, n_classes
…e chain, per order parameter
…fiegel/scikit-learn into verbose-to-classifier-regressor-chains pulling from GitHub
cmarmo
reviewed
Dec 7, 2020
There was a problem hiding this comment.
@efiegel thanks for your pull request. I've made some comments waiting for a core-dev review.
Also keep in mind that this is a new feature so it will need a what's new entry describing the new option and referring to your pull request.... as we are in the middle of a release you might want to wait some time ... I don't know myself if the release after will be 0.25 or 1.0 ... :D
glemaitre
reviewed
Dec 16, 2020
Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Chiara Marmo <[email protected]>
|
Thanks @glemaitre @cmarmo! Should have all your feedback folded in. |
|
Thanks @efiegel for your patience! Do you mind updating to upstream/main (again...sorry for that)? This and the "Waiting for reviewer" should bring more attention I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16380
What does this implement/fix? Explain your changes.
Adds a boolean verbose option to
ClassifierChainandRegressorChain.Follows the examples of #11364 and #16069.