FIX Show a HTML repr for meta-estimatosr with invalid parameters - #24015
Merged
glemaitre merged 4 commits intoJul 27, 2022
Conversation
jeremiedbb
approved these changes
Jul 26, 2022
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Member
|
Thanks @thomasjpfan LGTM. Merging |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…kit-learn#24015) Co-authored-by: Jérémie du Boisberranger <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
) Co-authored-by: Jérémie du Boisberranger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #24009
What does this implement/fix? Explain your changes.
For the case of
_sk_visual_block_, this PR enhances_get_visual_blockto have a better default if_sk_visual_block_fails for any reason. The default here is to treat the meta-estimator as a single estimator:Any other comments?
The alternative is to adjust all the meta-estimators and validate some parameters in
_sk_visual_block_.