FIX Allow BaseEstimator.get_params to handle type type params - #24017
Merged
glemaitre merged 6 commits intoJul 29, 2022
Merged
Conversation
glemaitre
approved these changes
Jul 28, 2022
glemaitre
left a comment
Member
There was a problem hiding this comment.
LGTM. We would need an entry in the changelog thought.
Contributor
Author
I pattern matched what I've seen in previous PRs (e.g. #24015) but am still getting a failing "Check Changelog" CI test - not sure what I've done wrong here. Should I have put in |
thomasjpfan
reviewed
Jul 29, 2022
BaseEstimator.get_params to handle type type paramsBaseEstimator.get_params to handle type type params
BaseEstimator.get_params to handle type type paramsBaseEstimator.get_params to handle type type params
Co-authored-by: Thomas J. Fan <[email protected]>
Member
|
All good. Thanks @hsorsky |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…ikit-learn#24017) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
…4017) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #24016
What does this implement/fix? Explain your changes.
Adds
typetype estimator param handling toget_paramsAny other comments?
None