Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC adding PDP for categorical features in highlights #25065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Nov 29, 2022

closes #25056
requires #25067

However, this is WIP because I found an underlying bug when writing the highlights.

@glemaitre glemaitre marked this pull request as draft November 29, 2022 10:22
@glemaitre glemaitre changed the title wip until fix DOC adding PDP for categorical features in highlights Nov 29, 2022
@glemaitre glemaitre added this to the 1.2 milestone Nov 29, 2022
@jeremiedbb jeremiedbb marked this pull request as ready for review November 30, 2022 09:13
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plot is cropped at the bottom (the name of some features)

@jeremiedbb jeremiedbb added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Nov 30, 2022
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 4501959 into scikit-learn:main Nov 30, 2022
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Dec 6, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation module:inspection To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC set categorical PDP as MajorFeature
3 participants