Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH cartesian accepts mixed dtypes arrays #25067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 29, 2022
Merged

ENH cartesian accepts mixed dtypes arrays #25067

merged 6 commits into from
Nov 29, 2022

Conversation

glemaitre
Copy link
Member

Fixes issues found when submitting #25065

cartesian was using the dtype of the first array to decide the dtype of the output array.
Now, we select the most permissive dtype from the passed input arrays.

I don't think that it was the original plan to support mixed dtype at first.

@glemaitre glemaitre added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Nov 29, 2022
@glemaitre glemaitre added this to the 1.2 milestone Nov 29, 2022
@glemaitre glemaitre mentioned this pull request Nov 29, 2022
Merged
thomasjpfan
thomasjpfan reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

lesteve
lesteve reviewed Nov 29, 2022
View reviewed changes
jeremiedbb
jeremiedbb approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glemaitre

lorentzenchr
lorentzenchr approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few nitpicks.

@glemaitre @lorentzenchr
Update sklearn/utils/extmath.py
878f2f9 
Co-authored-by: Christian Lorentzen <[email protected]>
glemaitre
glemaitre commented Nov 29, 2022
View reviewed changes
ogrisel
ogrisel approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well assuming CI is green.

@lorentzenchr
Copy link
Member

Auto merge would have been nice 😉

@lesteve
Copy link
Member

lesteve commented Nov 29, 2022

Auto merge would have been nice wink

I refrained myself very hard from saying this. Now that you have said it, I am not going to disagree 😉

@jeremiedbb jeremiedbb merged commit 86080bb into scikit-learn:main Nov 29, 2022
@jeremiedbb
Copy link
Member

dw I'm the auto-merge bot 😄

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Dec 6, 2022
@glemaitre @lorentzenchr @jeremiedbb
ENH cartesian accepts mixed dtypes arrays (scikit-learn#25067)
d956100 
Co-authored-by: Christian Lorentzen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

@thomasjpfan thomasjpfan thomasjpfan left review comments

@ogrisel ogrisel ogrisel approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:inspection module:utils To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@glemaitre @lorentzenchr @lesteve @jeremiedbb @ogrisel @thomasjpfan