ENH cartesian accepts mixed dtypes arrays #25067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
reviewed
Nov 29, 2022
Co-authored-by: Christian Lorentzen <[email protected]>
glemaitre
commented
Nov 29, 2022
ogrisel
approved these changes
Nov 29, 2022
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well assuming CI is green.
Member
|
Auto merge would have been nice 😉 |
Member
I refrained myself very hard from saying this. Now that you have said it, I am not going to disagree 😉 |
Member
|
dw I'm the auto-merge bot 😄 |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 6, 2022
Co-authored-by: Christian Lorentzen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues found when submitting #25065
cartesianwas using thedtypeof the first array to decide thedtypeof the output array.Now, we select the most permissive
dtypefrom the passed input arrays.I don't think that it was the original plan to support mixed
dtypeat first.