TST Fix openml parser implementation for pandas-dev - #26386
Merged
Conversation
adrinjalali
reviewed
May 17, 2023
adrinjalali
left a comment
Member
There was a problem hiding this comment.
This looks better to me. Does it need a changelog? It might be changing dtypes in some cases probably?
Member
|
I would consider this a fix because we have better dtypes. We should have an entry in what's new to acknowledge it. |
ogrisel
reviewed
May 17, 2023
| # with casting it will be transformed to either float or Int64 | ||
| (40966, "pandas", 1, 77, 0), | ||
| # titanic | ||
| (40945, "liac-arff", 3, 5, 0), |
Member
There was a problem hiding this comment.
I am a bit confused by this PR: why would fixing the pandas parser impact a test for the liac-arff parser?
Member
Author
There was a problem hiding this comment.
This PR is fixing the liac-arff parser which uses pandas when as_frame=True.
For this specific tests, the "body" feature is interpreted as a object dtype on main. With this PR, the "body" feature is a float dtype, which increases the expected_n_floats by one.
adrinjalali
approved these changes
May 22, 2023
Member
|
Merging, thanks a lot! |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partial Addresses #26154
Alternative to #26344
What does this implement/fix? Explain your changes.
This PR uses the second chunk to infer the dtypes and uses those types for the first chunk. For the titanic dataset, this means that
bodyfeature gets correctly inferred as a numeric dtype. OpenML denotes body as a numeric feature in it's metadata.