Fix AttributeError use_fallback_lbfgs_solve for newton-cholesky when fitting with max_iter=0 - #26653
Merged
jeremiedbb merged 7 commits intoJun 26, 2023
Conversation
…fitting with max_iter=0
Member
Author
|
/cc @lorentzenchr. |
Co-authored-by: Christian Lorentzen <[email protected]>
ogrisel
commented
Jun 22, 2023
lorentzenchr
approved these changes
Jun 23, 2023
jeremiedbb
enabled auto-merge (squash)
June 26, 2023 14:07
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jun 29, 2023
…fitting with max_iter=0 (scikit-learn#26653) Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb
added a commit
that referenced
this pull request
Jun 29, 2023
…fitting with max_iter=0 (#26653) Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
…fitting with max_iter=0 (scikit-learn#26653) Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…fitting with max_iter=0 (scikit-learn#26653) Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As found when trying to run
benchopton LogisticRegression with thenewton-choleskysolver.When writing the non-regression test, I found that both sag/saga and LBFGS also had problems with
max_iter=0but of a different nature (more minor as they would not raise an exception). See theXXXcomments for details.I plan to tackled those in dedicated follow-up PRs.
I think we should backport this fix to 1.3.0 (or 1.3.1 if the merge arrives too late).