✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 2c2ef80. Link to the linter CI: here}

I'm wondering why list(names) is needed, can you explain a bit @deepyaman? At first glance I think any iterable would work in _VisualBlock.

@adrinjalali thanks for the review, and @Charlie-XIAO sorry I missed your question!

I'm wondering why list(names) is needed, can you explain a bit @deepyaman? At first glance I think any iterable would work in _VisualBlock.

To be honest, it's been so long that I forgot (and obviously I didn't explain it properly in my comment...), but looking at the CI failure, I think it's because of this:

def test_get_visual_block_pipeline():
        pipe = Pipeline(
            [
                ("imputer", SimpleImputer()),
                ("do_nothing", "passthrough"),
                ("do_nothing_more", None),
                ("classifier", LogisticRegression()),
            ]
        )
        est_html_info = _get_visual_block(pipe)
        assert est_html_info.kind == "serial"
        assert est_html_info.estimators == tuple(step[1] for step in pipe.steps)
>       assert est_html_info.names == [
            "imputer: SimpleImputer",
            "do_nothing: passthrough",
            "do_nothing_more: passthrough",
            "classifier: LogisticRegression",
        ]
E       AssertionError

It seems _VisualBlock doesn't modify/coerce the passed names in any way, so it needs to be done somewhere to maintain the same attribute value/exact API.

It seems _VisualBlock doesn't modify/coerce the passed names in any way, so it needs to be done somewhere to maintain the same attribute value/exact API.

Upon second thought, I guess could change the test instead? _VisualBlock is not part of the public API, so I guess it should be OK to have .names be a tuple (if you all comfortable with the slight change, and aren't too worried about potential downstream effects). 🤷

Fixing the test sounds good.

@deepyaman would you be able to finish this PR?

@deepyaman would you be able to finish this PR?

Sorry, lot of things happened. :) Let me try and wrap it up later today, or on the weekend.

@adrinjalali @Charlie-XIAO Sorry for the delay on this; I've made the minor requested change in 99a2177!