-
-
Notifications
You must be signed in to change notification settings - Fork 26k
BLD Build wheels against released version of our dependencies #29538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeremiedbb
merged 2 commits into
scikit-learn:main
from
lesteve:build-wheels-against-numpy-release
Jul 22, 2024
Merged
BLD Build wheels against released version of our dependencies #29538
jeremiedbb
merged 2 commits into
scikit-learn:main
from
lesteve:build-wheels-against-numpy-release
Jul 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
oh, a segfault 😕 |
Oh well 😱 🤷, for later reference, just in case this was the
|
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #29301
What does this implement/fix? Explain your changes.
During the Numpy 2 transition, we were building our wheels against numpy development version to ensure that they were compatible with both numpy<2 and numpy>=2 (not yet released), see #27735.
Now that numpy 2 has been released this is not necessary.