Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BLD Build wheels against released version of our dependencies #29538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jul 22, 2024

Reference Issues/PRs

Fix #29301

What does this implement/fix? Explain your changes.

During the Numpy 2 transition, we were building our wheels against numpy development version to ensure that they were compatible with both numpy<2 and numpy>=2 (not yet released), see #27735.

Now that numpy 2 has been released this is not necessary.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Jul 22, 2024
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: af3e3e5. Link to the linter CI: here

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jeremiedbb
Copy link
Member

jeremiedbb commented Jul 22, 2024

oh, a segfault 😕
EDIT: it's gone, let's pretend it never happened :)

@jeremiedbb jeremiedbb merged commit 6f5dac0 into scikit-learn:main Jul 22, 2024
48 checks passed
@lesteve lesteve deleted the build-wheels-against-numpy-release branch July 22, 2024 09:01
@lesteve
Copy link
Member Author

lesteve commented Jul 22, 2024

Oh well 😱 🤷, for later reference, just in case this was the Build wheel cp310-macosx_arm64- build log and log excerpt:

  ...............sssssssss............................XX.................. [ 62%]
  ........................................................................ [ 62%]
  Fatal Python error: Segmentation fault
  
  Thread 0x00000001729bf000 (most recent call first):
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 320 in wait
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/joblib/externals/loky/backend/queues.py", line 147 in _feed
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 953 in run
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 973 in _bootstrap
  
  Thread 0x00000001719b3000 (most recent call first):
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/selectors.py", line 416 in select
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/multiprocessing/connection.py", line 931 in wait
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/joblib/externals/loky/process_executor.py", line 654 in wait_result_broken_or_wakeup
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/joblib/externals/loky/process_executor.py", line 596 in run
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
    File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 973 in _bootstrap
  
  Current thread 0x00000001eb3c0c00 (most recent call first):
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/numpy/lib/_arraysetops_impl.py", line 356 in _unique1d
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/numpy/lib/_arraysetops_impl.py", line 289 in unique
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/utils/_array_api.py", line 416 in unique_values
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/utils/multiclass.py", line 403 in type_of_target
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/utils/multiclass.py", line 210 in check_classification_targets
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/semi_supervised/_label_propagation.py", line 264 in fit
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/base.py", line 1514 in wrapper
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/semi_supervised/_label_propagation.py", line 482 in fit
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/utils/estimator_checks.py", line 3847 in check_fit_idempotent
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/sklearn/tests/test_common.py", line 169 in test_estimators
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/python.py", line 159 in pytest_pyfunc_call
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/python.py", line 1627 in runtest
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/runner.py", line 174 in pytest_runtest_call
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/runner.py", line 242 in <lambda>
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/runner.py", line 341 in from_call
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/runner.py", line 241 in call_and_report
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/runner.py", line 132 in runtestprotocol
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/runner.py", line 113 in pytest_runtest_protocol
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/main.py", line 362 in pytest_runtestloop
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/main.py", line 337 in _main
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/main.py", line 283 in wrap_session
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/main.py", line 330 in pytest_cmdline_main
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 175 in main
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 201 in console_main
    File "/private/var/folders/6g/_ypptv3n2fs80_zc0xz8p1d40000gn/T/cibw-run-yr4ffsw8/cp310-macosx_arm64/venv-test-arm64/bin/pytest", line 8 in <module>
  
  Extension modules: sklearn.__check_build._check_build, numpy._core._multiarray_umath, numpy._core._multiarray_tests, numpy.linalg._umath_linalg, scipy._lib._ccallback_c, numpy.random._common, numpy.random.bit_generator, numpy.random._bounded_integers, numpy.random._mt19937, numpy.random.mtrand, numpy.random._philox, numpy.random._pcg64, numpy.random._sfc64, numpy.random._generator, scipy.sparse._sparsetools, _csparsetools, scipy.sparse._csparsetools, scipy.linalg._fblas, scipy.linalg._flapack, scipy.linalg.cython_lapack, scipy.linalg._cythonized_array_utils, scipy.linalg._solve_toeplitz, scipy.linalg._decomp_lu_cython, scipy.linalg._matfuncs_sqrtm_triu, scipy.linalg.cython_blas, scipy.linalg._matfuncs_expm, scipy.linalg._decomp_update, scipy.sparse.linalg._dsolve._superlu, scipy.sparse.linalg._eigen.arpack._arpack, scipy.sparse.linalg._propack._spropack, scipy.sparse.linalg._propack._dpropack, scipy.sparse.linalg._propack._cpropack, scipy.sparse.linalg._propack._zpropack, scipy.sparse.csgraph._tools, scipy.sparse.csgraph._shortest_path, scipy.sparse.csgraph._traversal, scipy.sparse.csgraph._min_spanning_tree, scipy.sparse.csgraph._flow, scipy.sparse.csgraph._matching, scipy.sparse.csgraph._reordering, scipy.special._ufuncs_cxx, scipy.special._ufuncs, scipy.special._specfun, scipy.special._comb, scipy.special._ellip_harm_2, scipy.spatial._ckdtree, scipy._lib.messagestream, scipy.spatial._qhull, scipy.spatial._voronoi, scipy.spatial._distance_wrap, scipy.spatial._hausdorff, scipy.spatial.transform._rotation, scipy.optimize._group_columns, scipy.optimize._trlib._trlib, scipy.optimize._lbfgsb, _moduleTNC, scipy.optimize._moduleTNC, scipy.optimize._cobyla, scipy.optimize._slsqp, scipy.optimize._minpack, scipy.optimize._lsq.givens_elimination, scipy.optimize._zeros, scipy.optimize._highs.cython.src._highs_wrapper, scipy.optimize._highs._highs_wrapper, scipy.optimize._highs.cython.src._highs_constants, scipy.optimize._highs._highs_constants, scipy.linalg._interpolative, scipy.optimize._bglu_dense, scipy.optimize._lsap, scipy.optimize._direct, scipy.integrate._odepack, scipy.integrate._quadpack, scipy.integrate._vode, scipy.integrate._dop, scipy.integrate._lsoda, scipy.interpolate._fitpack, scipy.interpolate._dfitpack, scipy.interpolate._bspl, scipy.interpolate._ppoly, scipy.interpolate.interpnd, scipy.interpolate._rbfinterp_pythran, scipy.interpolate._rgi_cython, scipy.special.cython_special, scipy.stats._stats, scipy.stats._biasedurn, scipy.stats._levy_stable.levyst, scipy.stats._stats_pythran, scipy._lib._uarray._uarray, scipy.stats._ansari_swilk_statistics, scipy.stats._sobol, scipy.stats._qmc_cy, scipy.stats._mvn, scipy.stats._rcont.rcont, scipy.stats._unuran.unuran_wrapper, scipy.ndimage._nd_image, _ni_label, scipy.ndimage._ni_label, sklearn.utils._isfinite, sklearn.utils.sparsefuncs_fast, sklearn.utils.murmurhash, sklearn.utils._openmp_helpers, sklearn.preprocessing._csr_polynomial_expansion, sklearn.preprocessing._target_encoder_fast, scipy.io.matlab._mio_utils, scipy.io.matlab._streams, scipy.io.matlab._mio5_utils, sklearn.datasets._svmlight_format_fast, sklearn.utils._random, sklearn.utils._vector_sentinel, sklearn.feature_extraction._hashing_fast, _loss, sklearn._loss._loss, sklearn.metrics.cluster._expected_mutual_info_fast, sklearn.metrics._dist_metrics, sklearn.metrics._pairwise_distances_reduction._datasets_pair, sklearn.utils._cython_blas, sklearn.metrics._pairwise_distances_reduction._base, sklearn.metrics._pairwise_distances_reduction._middle_term_computer, sklearn.utils._heap, sklearn.utils._sorting, sklearn.metrics._pairwise_distances_reduction._argkmin, sklearn.metrics._pairwise_distances_reduction._argkmin_classmode, sklearn.metrics._pairwise_distances_reduction._radius_neighbors, sklearn.metrics._pairwise_distances_reduction._radius_neighbors_classmode, sklearn.metrics._pairwise_fast, sklearn.utils._fast_dict, sklearn.cluster._hierarchical_fast, sklearn.cluster._k_means_common, sklearn.cluster._k_means_elkan, sklearn.cluster._k_means_lloyd, sklearn.cluster._k_means_minibatch, sklearn.neighbors._partition_nodes, sklearn.neighbors._ball_tree, sklearn.neighbors._kd_tree, sklearn.utils.arrayfuncs, sklearn.utils._seq_dataset, sklearn.linear_model._cd_fast, sklearn.svm._liblinear, sklearn.svm._libsvm, sklearn.svm._libsvm_sparse, sklearn.utils._weight_vector, sklearn.linear_model._sgd_fast, sklearn.linear_model._sag_fast, sklearn.decomposition._online_lda_fast, sklearn.decomposition._cdnmf_fast, sklearn.cluster._dbscan_inner, sklearn.cluster._hdbscan._tree, sklearn.cluster._hdbscan._linkage, sklearn.cluster._hdbscan._reachability, sklearn._isotonic, sklearn.tree._utils, sklearn.tree._tree, sklearn.tree._partitioner, sklearn.tree._splitter, sklearn.tree._criterion, sklearn.neighbors._quad_tree, sklearn.manifold._barnes_hut_tsne, sklearn.manifold._utils, scipy.cluster._vq, scipy.cluster._hierarchy, scipy.cluster._optimal_leaf_ordering, sklearn.ensemble._gradient_boosting, sklearn.ensemble._hist_gradient_boosting.common, sklearn.ensemble._hist_gradient_boosting._gradient_boosting, sklearn.ensemble._hist_gradient_boosting._binning, sklearn.ensemble._hist_gradient_boosting._bitset, sklearn.ensemble._hist_gradient_boosting.histogram, sklearn.ensemble._hist_gradient_boosting._predictor, sklearn.ensemble._hist_gradient_boosting.splitting, sklearn.svm._newrand, pandas._libs.tslibs.ccalendar, pandas._libs.tslibs.np_datetime, pandas._libs.tslibs.dtypes, pandas._libs.tslibs.base, pandas._libs.tslibs.nattype, pandas._libs.tslibs.timezones, pandas._libs.tslibs.fields, pandas._libs.tslibs.timedeltas, pandas._libs.tslibs.tzconversion, pandas._libs.tslibs.timestamps, pandas._libs.properties, pandas._libs.tslibs.offsets, pandas._libs.tslibs.strptime, pandas._libs.tslibs.parsing, pandas._libs.tslibs.conversion, pandas._libs.tslibs.period, pandas._libs.tslibs.vectorized, pandas._libs.ops_dispatch, pandas._libs.missing, pandas._libs.hashtable, pandas._libs.algos, pandas._libs.interval, pandas._libs.lib, pandas._libs.ops, pandas._libs.hashing, pandas._libs.arrays, pandas._libs.tslib, pandas._libs.sparse, pandas._libs.internals, pandas._libs.indexing, pandas._libs.index, pandas._libs.writers, pandas._libs.join, pandas._libs.window.aggregations, pandas._libs.window.indexers, pandas._libs.reshape, pandas._libs.groupby, pandas._libs.json, pandas._libs.parsers, pandas._libs.testing, sklearn.utils._typedefs (total: 211)
  /Users/runner/work/scikit-learn/scikit-learn/build_tools/wheels/test_wheels.sh: line 26:  6149 Segmentation fault: 11  pytest --pyargs sklearn
  .............................................................::endgroup::Testing wheel...
  Error: Command ['/bin/sh', '-c', 'bash /Users/runner/work/scikit-learn/scikit-learn/build_tools/wheels/test_wheels.sh'] failed with code 139. 
                                                              ✕ 326.83s
  
  Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels against Numpy 2 rather than numpy development version
2 participants