DOC Improve the plot_gpy_noisy.py example #29788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ArturoAmorQ if you want to have a look. |
|
I'm the culprit for this one. I'll give a review. Could you remove all the "will" and use the present tense :) |
glemaitre
reviewed
Sep 5, 2024
glemaitre
reviewed
Sep 5, 2024
glemaitre
approved these changes
Sep 5, 2024
|
Enabling auto-merge. I'll change the use of "will" in another PR. Thanks @ogrisel |
I missed that part. I can also do the follow-up PR tomorrow if needed. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing GP related issues and PR and found out that this example had several imprecise / misleading phrasing.
I also took the opportunity to tweak the resolution of the plots and to empirically illustrate the final comment on random restart by show how to use
n_restarts_optimizerin practice.