-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC add link to plot_semi_supervised_newsgroups.py example in semi_supervised.rst #30882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @StefanieSenger. Please let me know if the changes I've made in this PR are correct. I modify it if needed. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @elhambbi. That looks very good.
Would you like to check if we can merge this, @adrinjalali?
The link is alright, but looking at the example, it looks really poor, and really old in terms of lack of notebook styling, good explanation of the example, and lacking any plots. How do you think we can improve the example @StefanieSenger ? |
So if you are up to it you could take on improving this example, @elhambbi. It could be something minimal as in #30476 or something more elaborated as in #30990, or something in between as in #29788, #29788 or #29149 (so you have some idea of how improving an example could look like). In terms of content I could imagine to
More on the technical side, you could
Would you be willing to work on that, @elhambbi? |
Hi @StefanieSenger . Sure, thank you. I'd be happy to help with improving this example. As soon as I have something done, I'll let you know. |
@adrinjalali, can we merge this PR already? The example is updated in another PR. |
I think the link can be added in the same PR as #31104, so that the link is added at the same time as the example is improved. Therefore closing this PR. |
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
The example for semi-supervised classification was not referenced. I added it in semi-supervised section in the user guide.
Any other comments?