Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC add link to plot_semi_supervised_newsgroups.py example in semi_supervised.rst #30882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

elhambbi
Copy link
Contributor

Reference Issues/PRs

Towards #30621

What does this implement/fix? Explain your changes.

The example for semi-supervised classification was not referenced. I added it in semi-supervised section in the user guide.

Any other comments?

Copy link

github-actions bot commented Feb 23, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b051377. Link to the linter CI: here

@StefanieSenger StefanieSenger self-requested a review February 23, 2025 21:52
@elhambbi
Copy link
Contributor Author

Hi @StefanieSenger. Please let me know if the changes I've made in this PR are correct. I modify it if needed. Thank you.

Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @elhambbi. That looks very good.

Would you like to check if we can merge this, @adrinjalali?

@adrinjalali
Copy link
Member

The link is alright, but looking at the example, it looks really poor, and really old in terms of lack of notebook styling, good explanation of the example, and lacking any plots.

How do you think we can improve the example @StefanieSenger ?

@StefanieSenger
Copy link
Contributor

So if you are up to it you could take on improving this example, @elhambbi.

It could be something minimal as in #30476 or something more elaborated as in #30990, or something in between as in #29788, #29788 or #29149 (so you have some idea of how improving an example could look like).

In terms of content I could imagine to

  • a bar chart can compare the f1 scores from eval_and_print_metrics()
  • describe how adding SelfTrainingClassifier or LabelSpreading to the pipeline improves performance compared to training a supervised model on only on 20 % of the data
  • add sub captions and short descriptions or comments to describe what is happening

More on the technical side, you could

  • remove the if __name__ == "__main__":
  • convert old string representations (like "%d documents" % ...) into f-strings
  • stop printing verbose output for all the iteration in SelfTrainingClassifier

Would you be willing to work on that, @elhambbi?

@elhambbi
Copy link
Contributor Author

So if you are up to it you could take on improving this example, @elhambbi.

It could be something minimal as in #30476 or something more elaborated as in #30990, or something in between as in #29788, #29788 or #29149 (so you have some idea of how improving an example could look like).

In terms of content I could imagine to

  • a bar chart can compare the f1 scores from eval_and_print_metrics()
  • describe how adding SelfTrainingClassifier or LabelSpreading to the pipeline improves performance compared to training a supervised model on only on 20 % of the data
  • add sub captions and short descriptions or comments to describe what is happening

More on the technical side, you could

  • remove the if __name__ == "__main__":
  • convert old string representations (like "%d documents" % ...) into f-strings
  • stop printing verbose output for all the iteration in SelfTrainingClassifier

Would you be willing to work on that, @elhambbi?

Hi @StefanieSenger . Sure, thank you. I'd be happy to help with improving this example. As soon as I have something done, I'll let you know.

@StefanieSenger
Copy link
Contributor

@adrinjalali, can we merge this PR already? The example is updated in another PR.

@adrinjalali
Copy link
Member

I think the link can be added in the same PR as #31104, so that the link is added at the same time as the example is improved. Therefore closing this PR.

@adrinjalali adrinjalali closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants