-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Enhanced classifier comparison example with Gradient Boosting Classifier and improved comments #30476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Wilbebs
commented
Dec 12, 2024
- Added a summary at the top of the file for clarity.
- Enhanced comments for classifiers, datasets, and visualizations.
- Added the Gradient Boosting Classifier as a new feature to improve functionality.
- Improved the script's clarity and made it more accessible for new contributors.
❌ Linting issuesThis PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling You can see the details of the linting issues under the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example also needs to become more notebook style, like other modern examples we have. Eg.: plot_forest_hist_grad_boosting_comparison.py
You also need to enable your pre-commit
hooks to fix your linting issues.
from sklearn.ensemble import ( | ||
AdaBoostClassifier, | ||
RandomForestClassifier, | ||
GradientBoostingClassifier, # Gradient Boosting added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use HistGradientBoostingClassifier
instead
""" | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
""" |
Hi @Wilbebs! Would you like to continue working on this pull request? |