docs: implement responsive multi-column layout for emeritus contributors to reduce whitespace #31565
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors to reduce whitespace (scikit-learn#31548)
|
@bl3ck Thank you for the PR. The layout looks good, and doesn't require manual insertion of names and we can keep the maintainers_emeritus.rst file, so that's a plus. I am not sure why the tests are failing. |
|
Hi @reshamas, happy to contribute! Your work with scikit-learn and open source is a big reason I wanted to get involved. The test failure looks like an intermittent issue with |
|
@reshamas All tests pass now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #31548
What does this implement/fix? Explain your changes.
This PR improves the layout of the emeritus contributors section on the About Us page by introducing a new utility class:
grid-list-three-columns, which provides a responsive, three-column layout.The updated layout reduces excess whitespace and helps users reach key sections more quickly, as recommended by @reshamas. The layout switches to a single column on smaller screens for better accessibility and readability.
Results:
Any other comments?
This change also helps maintain visual consistency with other parts of the documentation that use multi-column formatting.