-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
ENH: StratifiedShuffleSplit to mentione classes with too few members #32265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adrinjalali
merged 7 commits into
scikit-learn:main
from
MarcBresson:enh/clearer-split-error
Oct 7, 2025
Merged
ENH: StratifiedShuffleSplit to mentione classes with too few members #32265
adrinjalali
merged 7 commits into
scikit-learn:main
from
MarcBresson:enh/clearer-split-error
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR. Nice idea. But CI failing. |
adrinjalali
approved these changes
Oct 6, 2025
virchan
approved these changes
Oct 6, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @MarcBresson!
@adrinjalali, could we merge this?
Tunahanyrd
pushed a commit
to Tunahanyrd/scikit-learn
that referenced
this pull request
Oct 28, 2025
…cikit-learn#32265) Co-authored-by: Adrin Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module:model_selection
Quick Review
For PRs that are quick to review
Waiting for Second Reviewer
First reviewer is done, need a second one!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…w members
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR improves the error message raised during a split. The new error message will write down classes with not enough samples to ease identification.
Any other comments?