Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MarcBresson
Copy link
Contributor

…w members

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR improves the error message raised during a split. The new error message will write down classes with not enough samples to ease identification.

Any other comments?

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 074bd79. Link to the linter CI: here

@adrinjalali
Copy link
Member

Thanks for the PR. Nice idea. But CI failing.

@adrinjalali adrinjalali changed the title ENH: improve error message during split by naming classes with too fe… ENH: StratifiedShuffleSplit to mentione classes with too few members Sep 25, 2025
@adrinjalali adrinjalali added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Oct 6, 2025
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @MarcBresson!

@adrinjalali, could we merge this?

@adrinjalali adrinjalali merged commit 444c20d into scikit-learn:main Oct 7, 2025
36 checks passed
Tunahanyrd pushed a commit to Tunahanyrd/scikit-learn that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:model_selection Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants