[Callbacks] ENH Avoid repeating the no callback support warning - #34026
Closed
FrancoisPgm wants to merge 1 commit into
Closed
[Callbacks] ENH Avoid repeating the no callback support warning#34026FrancoisPgm wants to merge 1 commit into
FrancoisPgm wants to merge 1 commit into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #33328
This a rework of jeremiedbb#33
What does this implement/fix? Explain your changes.
Lazily create an attribute on the root context recording the messages of raised warnings for no callback support in a sub-estimator, so that if the warning is raised only once. This fix does not work when parallelizing the meta-estimator, but I don't see how to tackle that case without introducing some inter threads or processes communication and I don't think it would be worth it.
Add a check in the tests that the warning is only raised once.
Remove
test_inner_estimator_no_callback_supportwhich was testing the warning, as it is redundant withtest_autopropagation_to_callback_agnostic_subestimator.Update the warning message to make it slightly clearer.
AI usage disclosure
I used AI assistance for:
Any other comments?
ping @jeremiedbb, @StefanieSenger