MNT Avoid repeating the no callback support warning - #34055
Merged
jeremiedbb merged 9 commits intoJun 2, 2026
Conversation
jeremiedbb
reviewed
May 21, 2026
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
Here are some suggestions.
jeremiedbb
reviewed
May 27, 2026
Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb
approved these changes
May 28, 2026
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
I don't think that a changelog is needed for that. LGTM
StefanieSenger
approved these changes
May 28, 2026
Member
There was a problem hiding this comment.
I think we should test the error message is correct, to make sure it is not a different UserWarning that gets caught. Otherwise this could become hard to debug, if we introduce another UserWarning somewhere in the process in the future.
Also, two very nits. Apart from that LGTM.
Thanks, @FrancoisPgm!
Co-authored-by: Stefanie Senger <[email protected]>
Member
|
hummm. I forgot about this one. I would have liked to include it in 1.9... 🤦 |
jeremiedbb
enabled auto-merge (squash)
June 2, 2026 15:37
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Stefanie Senger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
reopening of #34026 after the deletion of the callbacks branch.
What does this implement/fix? Explain your changes.
Lazily create an attribute on the root context recording the messages of raised warnings for no callback support in a sub-estimator, so that if the warning is raised only once. This fix does not work when parallelizing the meta-estimator, but I don't see how to tackle that case without introducing some inter threads or processes communication and I don't think it would be worth it.
Add a check in the tests that the warning is only raised once.
Remove test_inner_estimator_no_callback_support which was testing the warning, as it is redundant with test_autopropagation_to_callback_agnostic_subestimator.
Update the warning message to make it slightly clearer.
AI usage disclosure
I used AI assistance for:
Any other comments?
ping @jeremiedbb @StefanieSenger