Closed
Make BLIS reproducers enforce actual backend selection and fix C runner portability#34169
Conversation
Copilot
AI
changed the title
WIP: Add macOS arm64 BLIS minimal repro workflows
WIP: Add macOS arm64 BLIS repro harness (NumPy + pure C) with isolated CI workflow
Jun 1, 2026
Copilot created this pull request from a session on behalf of
ogrisel
June 1, 2026 15:38
View session
Copilot
AI
changed the title
WIP: Add macOS arm64 BLIS repro harness (NumPy + pure C) with isolated CI workflow
Fix BLIS C reproducer configure invocation on macOS arm64
Jun 1, 2026
Member
|
@copilot please disable the Circle CI config on this PR. Please also ensure that the description of the PR is summary of the motivation and technical content of the PR and the results of the analysis of the latest workflow runs at all times. |
Copilot
AI
changed the title
Fix BLIS C reproducer configure invocation on macOS arm64
Make BLIS reproducers enforce actual backend selection and fix C runner portability
Jun 1, 2026
Member
|
It's painful to use copilot on the main scikit-learn repo to iteratively craft this reproducer because of the manual workflow run approval. Let's close and try an alternative setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reproducer workflow was not reliably demonstrating the intended BLAS scenario, and the Python/C reproducers had drifted from the requested setup. This update tightens both reproducers so runs fail when the requested backend is not actually in effect and removes path assumptions that broke the C job.
C reproducer: path-safe and self-contained
build_and_run_c_blis_reproducer.sh.blis_gemm_reproducer.csource used by the script../configure --enable-cblas auto).Python reproducer: backend verification, not just execution
--expected-blastonumpy_blis_reproducer.py.Runner behavior alignment
run_numpy_blas_reproducer.shto pass--expected-blasexplicitly.newacceleratedoes not inherit OpenBLAS/BLIS thread vars.