Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make BLIS reproducers enforce actual backend selection and fix C runner portability - #34169

Closed
ogrisel with Copilot wants to merge 4 commits into
mainfrom
copilot/search-root-cause-openblas-to-blis
Closed

Make BLIS reproducers enforce actual backend selection and fix C runner portability#34169
ogrisel with Copilot wants to merge 4 commits into
mainfrom
copilot/search-root-cause-openblas-to-blis

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

The reproducer workflow was not reliably demonstrating the intended BLAS scenario, and the Python/C reproducers had drifted from the requested setup. This update tightens both reproducers so runs fail when the requested backend is not actually in effect and removes path assumptions that broke the C job.

  • C reproducer: path-safe and self-contained

    • Remove hardcoded checkout path usage in build_and_run_c_blis_reproducer.sh.
    • Resolve source paths relative to the script directory.
    • Add the missing blis_gemm_reproducer.c source used by the script.
    • Keep BLIS configure invocation in working order (./configure --enable-cblas auto).
  • Python reproducer: backend verification, not just execution

    • Add --expected-blas to numpy_blis_reproducer.py.
    • Detect NumPy BLAS backend at runtime and fail on mismatch.
    • Print detected backend in output for fast triage.
  • Runner behavior alignment

    • Update run_numpy_blas_reproducer.sh to pass --expected-blas explicitly.
    • Correct thread env handling so newaccelerate does not inherit OpenBLAS/BLIS thread vars.
    • Refresh README wording to reflect backend verification behavior.
# launcher now enforces backend intent
./build_tools/github/blis_reproducer/run_numpy_blas_reproducer.sh blis

# python reproducer now validates backend selection
python build_tools/github/blis_reproducer/numpy_blis_reproducer.py --expected-blas blis

Copilot AI changed the title WIP: Add macOS arm64 BLIS minimal repro workflows WIP: Add macOS arm64 BLIS repro harness (NumPy + pure C) with isolated CI workflow Jun 1, 2026
Copilot AI requested a review from ogrisel June 1, 2026 15:38
Copilot AI changed the title WIP: Add macOS arm64 BLIS repro harness (NumPy + pure C) with isolated CI workflow Fix BLIS C reproducer configure invocation on macOS arm64 Jun 1, 2026
@ogrisel

ogrisel commented Jun 1, 2026

Copy link
Copy Markdown
Member

@copilot please disable the Circle CI config on this PR. Please also ensure that the description of the PR is summary of the motivation and technical content of the PR and the results of the analysis of the latest workflow runs at all times.

Copilot AI changed the title Fix BLIS C reproducer configure invocation on macOS arm64 Make BLIS reproducers enforce actual backend selection and fix C runner portability Jun 1, 2026
@ogrisel

ogrisel commented Jun 2, 2026

Copy link
Copy Markdown
Member

It's painful to use copilot on the main scikit-learn repo to iteratively craft this reproducer because of the manual workflow run approval. Let's close and try an alternative setup.

@ogrisel ogrisel closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants