Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI Improve lockfile bot PR comment - #34546

Merged
jeremiedbb merged 1 commit into
scikit-learn:mainfrom
betatim:update-lockfile-bot-comment
Jul 22, 2026
Merged

CI Improve lockfile bot PR comment#34546
jeremiedbb merged 1 commit into
scikit-learn:mainfrom
betatim:update-lockfile-bot-comment

Conversation

@betatim

@betatim betatim commented Jul 22, 2026

Copy link
Copy Markdown
Member

Reference Issues/PRs

#34200 (comment)

What does this implement/fix? Explain your changes.

This adds the (likely) correct command you should run when dealing with failures in the PRs opened by the "lockfile update bot". For example #34409

While dealing with that I updated too many lockfiles which then got pointed out in #34200 (comment). This made me think we could add the command to the message the bot posts.

Any thoughts @lesteve? Is this likely to be the right command to run in "most of the cases"?

@betatim betatim changed the title Improve lockfile bot PR comment CI Improve lockfile bot PR comment Jul 22, 2026

@jeremiedbb jeremiedbb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jeremiedbb
jeremiedbb merged commit dfa0337 into scikit-learn:main Jul 22, 2026
41 checks passed
@lesteve

lesteve commented Jul 23, 2026

Copy link
Copy Markdown
Member

Thanks a lot! I was actually thinking of doing something like this. "Les grand esprits se rencontrent" as we say in French 😉.

As a possible follow-up you could also say something like, do remember to use [magical commit marker] in your commit to make sure the optional CI build passes. The info is in additional_commit_message field. If it's empty as in for the main CI you don't need to add this comment.

@betatim
betatim deleted the update-lockfile-bot-comment branch July 23, 2026 08:08
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants