[MRG+1] minor edits to multiclass documentation #5837
Conversation
|
[MRG] ready to be merged, please review |
| @@ -109,12 +109,12 @@ One-Vs-The-Rest | |||
| =============== | |||
|
|
|||
| This strategy, also known as **one-vs-all**, is implemented in | |||
| :class:`OneVsRestClassifier`. The strategy consists in fitting one classifier | |||
| :class:`OneVsRestClassifier`. The strategy consists of fitting one classifier | |||
There was a problem hiding this comment.
not sure. http://english.stackexchange.com/questions/95929/consists-of-vs-consists-in-different-meanings-of-the-verb-or-the-same-mea http://english.stackexchange.com/questions/61600/consist-in-vs-consist-of
I think it is telling that the first hits for "consists in" are of stackexchange discussing the usage of the phrase.
There was a problem hiding this comment.
I think "consists of" is better...
|
Nitpicks, but this looks good to me. |
| in a finite set of colors such as "green", "red", "orange", "yellow"... | ||
| For instance, a sample could be assigned "pear" for an output variable that | ||
| takes possible values in a finite set of species such as "pear" or "apple", | ||
| and "blue" or "green" for a second output variable that takes possible values |
|
please squash. LGTM apart from one comma, but I'm not a native speaker. |
|
ready to merge? |
| problem is restricted to binary classification, and of the multi-class | ||
| classification task. *The output format is a 2d numpy array or sparse | ||
| matrix.* | ||
| problems is restricted to binary classification, |
There was a problem hiding this comment.
Shouldn't this be problems are restricted?
| @@ -30,21 +30,21 @@ by decomposing such problems into binary classification problems. | |||
|
|
|||
| - **Multioutput-multiclass classification** and **multi-task classification** | |||
| means that a single estimator has to handle | |||
| several joint classification tasks. This is a generalization | |||
| several joint classification tasks. This is both a generalization | |||
| of the multi-label classification task, where the set of classification | |||
There was a problem hiding this comment.
I would say "which only considers binary classification". Currently the sentence is a bit awkward (what does "where" refer to?)
|
otherwise lgtm, please squash. |
|
now that we can rebase and squash in github, shall we do that here? |
There is no conflicts with master, so no need to rebase or squash. |
|
There is still an open comment, though... On 29 September 2016 at 19:41, Tom Dupré la Tour [email protected]
|
|
Eh, let's merge and fix in master? The sentence was awkward before. |
|
Done, thanks @pieteradejong |
* minor edits to multiclass documentation * minor text formatting and language modifications * minor word changes, sentence clarifications * attempt to fix ci test * restored previous paragraph * minor grammatical correction * minor grammar fixes
* minor edits to multiclass documentation * minor text formatting and language modifications * minor word changes, sentence clarifications * attempt to fix ci test * restored previous paragraph * minor grammatical correction * minor grammar fixes
* minor edits to multiclass documentation * minor text formatting and language modifications * minor word changes, sentence clarifications * attempt to fix ci test * restored previous paragraph * minor grammatical correction * minor grammar fixes
* minor edits to multiclass documentation * minor text formatting and language modifications * minor word changes, sentence clarifications * attempt to fix ci test * restored previous paragraph * minor grammatical correction * minor grammar fixes
minor changes to become familiar with the process