-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] Fix aesthetic example roc crossval #8232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jnothman I slightly change the example to get similar plot as in SO. |
If we're going to show the AUC for each fold in the legend, we need to mark each distinctively, still. Can you add a legend entry for the standard deviation? |
Can you also add an image of the new plot? |
FWIW, @NelleV: you can easily get to the CircleCI-rendered docs using this bookmarklet (although it seems GitHub keeps tweaking their HTML so I need to keep tweaking that script) |
@jnothman we really need this for Matplotlib... |
Does matplotlib have CI rendering docs and pushing to a public server as Circle CI does? Otherwise, the bookmarklet uses our "likely changed docs page" compiled by this code and incidentally exploits our web server having a URL shorthand for built docs |
We build our documentation on travis-ci, but this might be a good opportunity to see what we can do with circle-ci. |
@jnothman IMHO, I would keep only the mean/std AUC in the legend with the luck, implying that we would need a single colour. I made the changes such that you can compare with the SO aesthetic and make a choice. |
@NelleV I am not sure if this is what you mean by adding images? Matplotlib 1.5.3Matplotlib 2.0.0 |
@jnothman Now that I am seeing the legend with matplotlib 2.0, I would probably keep the individual ROC. |
:) yes, that looks good.
…On 25 January 2017 at 21:10, Guillaume Lemaitre ***@***.***> wrote:
@jnothman <https://github.com/jnothman> Now that I am seeing the legend
with matplotlib 2.0, I would probably keep the individual ROC.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6--T2qQT2hpY8Rm7VcVGz0jGM1zDks5rVx-xgaJpZM4Ls8eh>
.
|
When I said put the std in the legend, I meant show that that's what a grey mass means. Or else it can be noted in the example description. Otherwise LGTM. |
looks great. thx @glemaitre |
* Fix esthetic example roc crossval
* Fix esthetic example roc crossval
* Fix esthetic example roc crossval
* Fix esthetic example roc crossval
* Fix esthetic example roc crossval
Reference Issue
Issue #8227
What does this implement/fix? Explain your changes.
Make plot as suggested in SO regarding the aesthetic.
Any other comments?