Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] Fix aesthetic example roc crossval #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2017

Conversation

glemaitre
Copy link
Member

Reference Issue

Issue #8227

What does this implement/fix? Explain your changes.

Make plot as suggested in SO regarding the aesthetic.

Any other comments?

@glemaitre glemaitre changed the title Fix aesthetic example roc crossval [MRG] Fix aesthetic example roc crossval Jan 25, 2017
@glemaitre
Copy link
Member Author

@jnothman I slightly change the example to get similar plot as in SO.

@jnothman
Copy link
Member

If we're going to show the AUC for each fold in the legend, we need to mark each distinctively, still.

Can you add a legend entry for the standard deviation?

@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

Can you also add an image of the new plot?
It is possible that upgrading to Matplotlib 2.0 changes drastically the looks of this plot.

@jnothman
Copy link
Member

FWIW, @NelleV: you can easily get to the CircleCI-rendered docs using this bookmarklet (although it seems GitHub keeps tweaking their HTML so I need to keep tweaking that script)

@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

@jnothman we really need this for Matplotlib...

@jnothman
Copy link
Member

Does matplotlib have CI rendering docs and pushing to a public server as Circle CI does? Otherwise, the bookmarklet uses our "likely changed docs page" compiled by this code and incidentally exploits our web server having a URL shorthand for built docs

@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

We build our documentation on travis-ci, but this might be a good opportunity to see what we can do with circle-ci.

@glemaitre
Copy link
Member Author

@jnothman IMHO, I would keep only the mean/std AUC in the legend with the luck, implying that we would need a single colour. I made the changes such that you can compare with the SO aesthetic and make a choice.

@glemaitre
Copy link
Member Author

@NelleV I am not sure if this is what you mean by adding images?

Matplotlib 1.5.3

matplotlib_1_5_3

Matplotlib 2.0.0

matplotlib_2_0

@glemaitre
Copy link
Member Author

@jnothman Now that I am seeing the legend with matplotlib 2.0, I would probably keep the individual ROC.

@jnothman
Copy link
Member

jnothman commented Jan 25, 2017 via email

@jnothman
Copy link
Member

When I said put the std in the legend, I meant show that that's what a grey mass means. Or else it can be noted in the example description.

Otherwise LGTM.

@agramfort
Copy link
Member

looks great.

thx @glemaitre

@agramfort agramfort merged commit ec8d9f3 into scikit-learn:master Jan 25, 2017
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants