[MRG + 1] Correct typo in cross decomposition example (Fixes #8307) #8578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM. Will merge after CIs pass... |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…earn#8307) (scikit-learn#8578) * changed plsca to cca * corrected variable plsca in line 56-57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8307
Description
Error in compare cross decomposition method.
What does this implement/fix? Explain your changes.
The variable needs to be cca in lines 147-148. There was a typo which I corrected.
Any other comments?