[MRG+1] Update list of scorers #9230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI output looks fine to me: https://11662-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/modules/model_evaluation.html. |
|
I've checked this matches the list of valid scorers. LGTM, except for curious clustering metric ordering. Also wondering if clustering should appear last. |
jnothman
reviewed
Jun 27, 2017
doc/modules/model_evaluation.rst
Outdated
|
|
||
| **Clustering** | ||
| 'adjusted_rand_score' :func:`metrics.adjusted_rand_score` | ||
| 'adjusted_rand_score' :func:`metrics.adjusted_rand_score` |
There was a problem hiding this comment.
Not sure why this ordering is used within clustering.
There was a problem hiding this comment.
I agree, is there a reason not to use alphabetical ordering?
There was a problem hiding this comment.
I will change the ordering to alphabetical.
|
LGTM |
550cfb2 to
7f5cbf7
Compare
|
Changed ordering to alphabetical : ) |
|
Lgtm |
|
Thanks |
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Update list of scorers * change ordering of scorers to alphabetical
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Update list of scorers * change ordering of scorers to alphabetical
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* Update list of scorers * change ordering of scorers to alphabetical
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Update list of scorers * change ordering of scorers to alphabetical
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
* Update list of scorers * change ordering of scorers to alphabetical
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Update list of scorers * change ordering of scorers to alphabetical
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
* Update list of scorers * change ordering of scorers to alphabetical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9183
What does this implement/fix? Explain your changes.
This PR updates the list of scorers in doc/modules/model_evaluation
Any other comments?
No