[MRG] updated default solver of LogisticRegressionCV from lbfgs to be liblinear #9818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…near to be consistent its documentation and the default setting of solver for LogisticRegression
Good catch. It's definitely a mistake in the documentation. Can you fix the doc rather than changing the default? |
|
I thought this way is nicer as it's more consistent with the class |
|
it's not as simple as this. The order is like this because parameters where
added progressively and we did not want to break code without deprecation.
Cs suggest you can pass many values of C
|
|
Closing this one in favour of #9957. The easiest is to change the documentation not the default value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be consistent its documentation and the default setting of solver for
LogisticRegression
Reference Issue
no reference issue
What does this implement/fix? Explain your changes.
Otherwise, it's a mistake in the documentation
Any other comments?