Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature] Add --follow flag to scans command #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[Feature] Add --follow flag to scans command #2630

wants to merge 13 commits into from

Conversation

Freedisch
Copy link
Member

@Freedisch Freedisch commented Aug 23, 2024 •
edited
Loading

Description

This PR adds a follow flag to the scan command #189

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 472a0bc
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66d099cbc9239e0008a4f9db

J12934
J12934 requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

There are also still a lot of debug logs, which should be removed before merging this :)

Freedisch and others added 8 commits August 23, 2024 16:40
@Freedisch @J12934
Update scbctl/cmd/scans.go
a746893 
Co-authored-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Freedisch <[email protected]>
@Freedisch
remove unused functions and run gofmt
e65d3bc 
Signed-off-by: freedisch <[email protected]>
@Freedisch
feat: update read jobname through scan
1063b72 
Signed-off-by: freedisch <[email protected]>
@J12934
go fmt
a7350c6 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Adjust --follow flag description
d05736a 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Rewrite job fetching logic to fetch the scan job based on labels and …
2e13870 
…owner references

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Update / fix k8s error package import alias
243d201 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Run go mod tidy
82f85d9 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 enabled auto-merge (rebase) August 29, 2024 15:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

auto-merge was automatically disabled August 29, 2024 16:12

Rebase failed

@J12934 J12934 mentioned this pull request Sep 19, 2024
Merged
4 tasks
@J12934
Copy link
Member

J12934 commented Sep 19, 2024

recreated this pr by cherry-picking the commits onto a new branch: #2668

will close this PR now

@J12934 J12934 closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freedisch @J12934