Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add --follow flag to scbctl to scans command #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 8, 2024
Merged

Add --follow flag to scbctl to scans command #2668

merged 8 commits into from
Oct 8, 2024

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Sep 19, 2024

Description

This PR recreates #2630 which has weird conflicts, this should hopefully resolve it.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Freedisch and others added 8 commits September 19, 2024 12:04
@Freedisch @J12934
feat: add follow -flag on scan command
36adeb0 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
Update scbctl/cmd/scans.go
dff424b 
Co-authored-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Freedisch <[email protected]>
@Freedisch @J12934
remove unused functions and run gofmt
65dcdd6 
Signed-off-by: freedisch <[email protected]>
@J12934
Adjust --follow flag description
fd1f6fd 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Rewrite job fetching logic to fetch the scan job based on labels and …
d3c86f0 
…owner references

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
go mod tidy
f276dc0 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Remove unused code
3837146 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Remove unneeded code from main.go
c69d22d 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 added the cli Issues regarding the CLI Integration label Sep 19, 2024
@J12934 J12934 self-assigned this Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit c69d22d
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66ebfc310ef23a000979dc86

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@J12934 J12934 mentioned this pull request Sep 19, 2024
Closed
4 tasks
@J12934 J12934 requested a review from Ilyesbdlala October 6, 2024 00:12
@Ilyesbdlala Ilyesbdlala merged commit 6407ac1 into secureCodeBox:main Oct 8, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ilyesbdlala Ilyesbdlala Ilyesbdlala approved these changes

Assignees

@J12934 J12934

Labels
cli Issues regarding the CLI Integration
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J12934 @Ilyesbdlala @Freedisch