-
Notifications
You must be signed in to change notification settings - Fork 364
Images missing #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yup, that's the problem with building paths/folders. In your Pull Request, there's a change with image path: https://github.com/segmentio/segment-docs/pull/174/files#diff-e3144a881ed92eaaa367978fb31ce39e I used it and it works as you can see on this page: http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/connections/spec/identify/ |
Yes, paths changed a little. The
It's a matter of fixing the content of markdown files and add to images path a PS. or we can consider using absolute paths, however, at this point, I cannot tell if this is an easier way 😅Would need to test it out |
@jedrzejchalubek I'm just confused because even with prettylinks on, I've never seen this behavior in Jekyll so that it requires this path traversal. If you look at, for example https://github.com/docker/docker.github.io/blob/master/docker-hub/repos.md which builds https://docs.docker.com/docker-hub/repos/, you can see that it doesn't require this folder traversal. |
okay, I see what's going on here. I've just tested specifically this page http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/protocols/anomaly_detection/#forward-violations-to-a-slack-channel you mentioned before. It turns out that Jekyll is smart enough and both paths: However, something doesn't work very well on the staging. I guess there's nothing we can do about it. |
@noeemi thanks for testing that! I thought I was going crazy! @danielstjules @XavierAgostini Which of you knows the most about our S3 setup to troubleshoot? I'm seeing it correctly locally as well. 🤔 |
@sanscontext the issue is with the URL: |
@XavierAgostini As I pointed out upthread, this is not usual behavior for Jekyll and is a really poor experience. |
No images are showing on this page:
http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/protocols/anomaly_detection/#forward-violations-to-a-slack-channel
(Compare to https://segment.com/docs/protocols/anomaly_detection/ )
There is a link to http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/protocols/images/protocols_meta_source_setup.png
I confirmed that the image file is there and the markdown file hasn't been changed, but none of the images are showing up. Sounds like this is an issue with how we're building individual paths?
The text was updated successfully, but these errors were encountered: