Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Images missing #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanscontext opened this issue Oct 29, 2019 · 7 comments · Fixed by #221
Closed

Images missing #167

sanscontext opened this issue Oct 29, 2019 · 7 comments · Fixed by #221
Assignees

Comments

@sanscontext
Copy link
Contributor

No images are showing on this page:
http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/protocols/anomaly_detection/#forward-violations-to-a-slack-channel
(Compare to https://segment.com/docs/protocols/anomaly_detection/ )

There is a link to http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/protocols/images/protocols_meta_source_setup.png

I confirmed that the image file is there and the markdown file hasn't been changed, but none of the images are showing up. Sounds like this is an issue with how we're building individual paths?

@imklau imklau self-assigned this Oct 30, 2019
@imklau
Copy link
Contributor

imklau commented Oct 30, 2019

Yup, that's the problem with building paths/folders.

In your Pull Request, there's a change with image path: https://github.com/segmentio/segment-docs/pull/174/files#diff-e3144a881ed92eaaa367978fb31ce39e

I used it and it works as you can see on this page: http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/connections/spec/identify/

@jedrzejchalubek
Copy link
Contributor

jedrzejchalubek commented Oct 30, 2019

Yes, paths changed a little. The image folder stays in same spot, but index.html file of a page sits in a folder. Structure after Jekyll compilation looks like this:

images/
anomaly_detection/
    |-- index.html

It's a matter of fixing the content of markdown files and add to images path a ../ so they have a proper path.

PS. or we can consider using absolute paths, however, at this point, I cannot tell if this is an easier way 😅Would need to test it out

@sanscontext
Copy link
Contributor Author

@jedrzejchalubek I'm just confused because even with prettylinks on, I've never seen this behavior in Jekyll so that it requires this path traversal. If you look at, for example https://github.com/docker/docker.github.io/blob/master/docker-hub/repos.md which builds https://docs.docker.com/docker-hub/repos/, you can see that it doesn't require this folder traversal.

@imklau
Copy link
Contributor

imklau commented Nov 6, 2019

okay, I see what's going on here.
That was confusing for us too 😄

I've just tested specifically this page http://segment-docs-stage.s3-website-us-west-2.amazonaws.com/docsv2/protocols/anomaly_detection/#forward-violations-to-a-slack-channel you mentioned before.

It turns out that Jekyll is smart enough and both paths:
![](images/protocols_meta_source_setup.png)
![](../images/protocols_meta_source_setup.png)
work well.

However, something doesn't work very well on the staging.
Now, we have the same code locally and on your staging and there are differences between images visibility. Locally I can see all of the images no matter which path I use, but the staging can't handle that. Maybe it's something with your building scripts 🤔

I guess there's nothing we can do about it.

@sanscontext
Copy link
Contributor Author

@noeemi thanks for testing that! I thought I was going crazy!

@danielstjules @XavierAgostini Which of you knows the most about our S3 setup to troubleshoot? I'm seeing it correctly locally as well. 🤔

@XavierAgostini
Copy link
Contributor

XavierAgostini commented Nov 7, 2019

@sanscontext the issue is with the URL:
![](./../images/protocols_meta_source_setup.png)
This will work, so you just need to manually update the images paths for the broken images

@sanscontext
Copy link
Contributor Author

@XavierAgostini As I pointed out upthread, this is not usual behavior for Jekyll and is a really poor experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants