Thanks to visit codestin.com
Credit goes to github.com

Skip to content

reinstate feedback and personas-partial hider, plus fix redirect #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

reinstate feedback and personas-partial hider, plus fix redirect #174

merged 1 commit into from
Oct 30, 2019

Conversation

sanscontext
Copy link
Contributor

@sanscontext sanscontext commented Oct 29, 2019 •
edited
Loading

Fixing some of the frontmatter to align with the ongoing/current docs, for ease of content sync later.

This includes:

  • changing how we do the "hide feedback footer" for pages we don't want feedback on (for example, legal, or a page with redirects)
  • adding a redirect for the config-api reference page (which we did already in the main docs)
  • updating the personas partial and "hide" frontmatter.

jedrzejchalubek
jedrzejchalubek approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@jedrzejchalubek jedrzejchalubek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also fixes this issue #167

@sanscontext
Copy link
Contributor Author

@jedrzejchalubek It only solves #167 manually, for that one file. 🤔 Unless you're seeing something different from what I'm seeing?

@sanscontext sanscontext merged commit 5f93362 into master Oct 30, 2019
@sanscontext sanscontext deleted the feedback-n-redirects branch October 30, 2019 16:25
bot-docsteam added a commit that referenced this pull request Jan 14, 2022
@bot-docsteam
Merge pull request #174 from segmentio/repo-sync
8c88f23 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedrzejchalubek jedrzejchalubek jedrzejchalubek approved these changes

@XavierAgostini XavierAgostini Awaiting requested review from XavierAgostini

@danielstjules danielstjules Awaiting requested review from danielstjules

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanscontext @jedrzejchalubek