Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DNI] Support coopvec with dxc april preview #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Apr 8, 2025

This PR contains changes to use the builtin functions that will be implemented by DXC April release.

@jkwak-work jkwak-work self-assigned this Apr 8, 2025
@jkwak-work jkwak-work added pr: non-breaking PRs without breaking changes pr: breaking change PRs with breaking changes and removed pr: non-breaking PRs without breaking changes pr: breaking change PRs with breaking changes labels Apr 8, 2025
@jkwak-work
Copy link
Collaborator Author

Closes #6758

@16-Bit-Dog
Copy link
Contributor

16-Bit-Dog commented Apr 10, 2025

Related to this PR, I noticed that in slang-capabilities.capdef that there is the definition alias cooperative_vector = _sm_6_8 | cpp | _cuda_sm_9_0 | spvCooperativeVectorNV;

This definition is likely supposed to use _sm_6_9 as per coop-vector requiring shader model 6.9.

This would likely cause issues/confusion if not updated for users (since sm_6_8 does not have support for coop-vectors).

@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_april_preview branch 3 times, most recently from 384990a to a050d59 Compare April 22, 2025 05:52
@jkwak-work
Copy link
Collaborator Author

Related to this PR, I noticed that in slang-capabilities.capdef that there is the definition alias cooperative_vector = _sm_6_8 | cpp | _cuda_sm_9_0 | spvCooperativeVectorNV;

This definition is likely supposed to use _sm_6_9 as per coop-vector requiring shader model 6.9.

This would likely cause issues/confusion if not updated for users (since sm_6_8 does not have support for coop-vectors).

Thank you very much.
That is correct and I fix it at the latest change.

@jkwak-work
Copy link
Collaborator Author

Currently the following tests are failing:

FAILED test: 'tests/cooperative-vector/load-store-groupshared.slang.1 (dx12)'
FAILED test: 'tests/cooperative-vector/load-store-rwbyteaddressbuffer.slang.1 (dx12)'

I am not sure how to load from groupshared with the long-vector syntax.

@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_april_preview branch from 24be844 to e04d764 Compare April 22, 2025 08:02
@jkwak-work
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_april_preview branch from 486e342 to 6ca7dc2 Compare April 28, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants