Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[DNI] Support coopvec with dxc april preview#6763

Closed
jkwak-work wants to merge 6 commits intoshader-slang:masterfrom
jkwak-work:feature/support_coopvec_with_dxc_april_preview
Closed

[DNI] Support coopvec with dxc april preview#6763
jkwak-work wants to merge 6 commits intoshader-slang:masterfrom
jkwak-work:feature/support_coopvec_with_dxc_april_preview

Conversation

@jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Apr 8, 2025

This PR contains changes to use the builtin functions that will be implemented by DXC April release.

@jkwak-work jkwak-work self-assigned this Apr 8, 2025
@jkwak-work jkwak-work added pr: non-breaking PRs without breaking changes pr: breaking change PRs with breaking changes and removed pr: non-breaking PRs without breaking changes pr: breaking change PRs with breaking changes labels Apr 8, 2025
@jkwak-work
Copy link
Collaborator Author

Closes #6758

@16-Bit-Dog
Copy link
Contributor

16-Bit-Dog commented Apr 10, 2025

Related to this PR, I noticed that in slang-capabilities.capdef that there is the definition alias cooperative_vector = _sm_6_8 | cpp | _cuda_sm_9_0 | spvCooperativeVectorNV;

This definition is likely supposed to use _sm_6_9 as per coop-vector requiring shader model 6.9.

This would likely cause issues/confusion if not updated for users (since sm_6_8 does not have support for coop-vectors).

@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_april_preview branch 3 times, most recently from 384990a to a050d59 Compare April 22, 2025 05:52
@jkwak-work
Copy link
Collaborator Author

Related to this PR, I noticed that in slang-capabilities.capdef that there is the definition alias cooperative_vector = _sm_6_8 | cpp | _cuda_sm_9_0 | spvCooperativeVectorNV;

This definition is likely supposed to use _sm_6_9 as per coop-vector requiring shader model 6.9.

This would likely cause issues/confusion if not updated for users (since sm_6_8 does not have support for coop-vectors).

Thank you very much.
That is correct and I fix it at the latest change.

@jkwak-work
Copy link
Collaborator Author

Currently the following tests are failing:

FAILED test: 'tests/cooperative-vector/load-store-groupshared.slang.1 (dx12)'
FAILED test: 'tests/cooperative-vector/load-store-rwbyteaddressbuffer.slang.1 (dx12)'

I am not sure how to load from groupshared with the long-vector syntax.

@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_april_preview branch from 24be844 to e04d764 Compare April 22, 2025 08:02
@jkwak-work
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

@jkwak-work jkwak-work force-pushed the feature/support_coopvec_with_dxc_april_preview branch from 486e342 to 6ca7dc2 Compare April 28, 2025 19:44
@jkwak-work
Copy link
Collaborator Author

A more proper PR was merged today.
Closing this.

@jkwak-work jkwak-work closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: non-breaking PRs without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants