-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[BUG] CNTCClassifier throws error when you provide callbacks. #8660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! I updated the test configuration so the tests run - they were currently skipped, but now I moved them to a separate VM. |
You can add test configurations in the |
Hi @fkiraly ! Thank you for update |
I think you should add another example to |
88c9081
to
23bacdc
Compare
Hi @fkiraly ! I've added new test case for callbacks, let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, thanks - looks great!
(I added a conditional to isolate the soft dependency in get_test_params
)
failures are unrelated |
Reference Issues/PRs
Fixes #8659
What does this implement/fix? Explain your changes.
This change fixes a problem, which occurred when you've provided CNTC with callbacks arguments.
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Should I add a test? If so where? There doesn't seem to be any tests for cntc.py.
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktime
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
maintainers
tag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.